Select the latest product version in showfor picker if user's version exceeds selectable options

[LeoMcA]

From: https://bugzilla.mozilla.org/show_bug.cgi?id=1743073

This should be possible with a small tweak to our showfor.js code. For nightly users, the following block gets executed:

if (type === 'version') {
  target = select(this.data.versions[product], val);
  if (target !== null) {
    extra['data-min'] = target.min_version;
    extra['data-max'] = target.max_version;
  }
}

https://github.com/mozilla/kitsune/blob/88701d663c5f0e5d24a9e75794a054e422d0f4da/kitsune/sumo/static/sumo/js/showfor.js#L96-L101

And target becomes null, since (e.g.) fx96 doesn't exist in this.data.versions[product]. We catch that null value below, and return nothing, so the select box just uses the default:

// This will fail if there is no version/product/platform that
// matches the desired val.
if (target === null) {
  return;
}

https://github.com/mozilla/kitsune/blob/88701d663c5f0e5d24a9e75794a054e422d0f4da/kitsune/sumo/static/sumo/js/showfor.js#L110-L114

Here we could instead set target to the most recent version from this.data.versions[product] if val is greater than it (with appropriate guards against conditions like "fx71" < "fx8" returning true). I'm not sure if we can rely on this.data.versions[product] being ordered.

[AliceWyman]

This is still a problem (see https://bugzilla.mozilla.org/show_bug.cgi?id=1830284#c6 for an example).

[AliceWyman]

This is still a problem. For example, see https://bugzilla.mozilla.org/show_bug.cgi?id=1957915#c1

[akatsoulas]

PR mozilla/kitsune#6613

[akatsoulas]

PR mozilla/kitsune#6614

[emilghittasv]

I can confirm that this issue is verified fixed in stage.

I'm moving this ticket inside the release column.